[ADT] Remove an obsolete forward declaration (NFC) #156391
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just removed CastInfoPointerUnionImpl in: commit 2d216a9 Author: Kazu Hirata <kazu@google.com> Date: Mon Sep 1 08:04:49 2025 -0700 This patch removes the obsolete forward declaration.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesWe just removed CastInfoPointerUnionImpl in: commit 2d216a9 This patch removes the obsolete forward declaration. Full diff: https://github.com/llvm/llvm-project/pull/156391.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/PointerUnion.h b/llvm/include/llvm/ADT/PointerUnion.h
index 24caa960c718d..ca0e1ed3d49d1 100644
--- a/llvm/include/llvm/ADT/PointerUnion.h
+++ b/llvm/include/llvm/ADT/PointerUnion.h
@@ -88,9 +88,6 @@ namespace pointer_union_detail {
};
}
-// This is a forward declaration of CastInfoPointerUnionImpl
-// Refer to its definition below for further details
-template <typename... PTs> struct CastInfoPointerUnionImpl;
/// A discriminated union of two or more pointer types, with the discriminator
/// in the low bit of the pointer.
///
|
arsenm
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just removed CastInfoPointerUnionImpl in:
commit 2d216a9
Author: Kazu Hirata kazu@google.com
Date: Mon Sep 1 08:04:49 2025 -0700
This patch removes the obsolete forward declaration.