Skip to content

[utils] Process attribute references in lines defining attrs. #156541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[utils] Process attribute references in lines defining attrs. #156541

wants to merge 1 commit into from
+3 −1

Conversation

vzakhari
Copy link
Contributor

@vzakhari vzakhari commented Sep 2, 2025 •
edited
Loading

Here is an example of TBAA attributes generated by Flang:

#tbaa_root = #llvm.tbaa_root<id = "Flang function root _QPtest6">
#tbaa_type_desc = #llvm.tbaa_type_desc<id = "any access", members = {<#tbaa_root, 0>}>

We have to process the text after = to replace the attribute
references with proper check variables.

@vzakhari
[utils] Process attribute references in lines defining attrs.
2d5a9ca 
Here is an example of TBAA attributes generated by Flang:
```
```

We have to process the test after `=` to replace the attribute
references with proper check variables.
@vzakhari vzakhari changed the title [utils] Process attribute references in lines defining attrs.' [utils] Process attribute references in lines defining attrs. Sep 4, 2025
@vzakhari vzakhari requested review from abidh and tblah September 5, 2025 03:48
@vzakhari
Copy link
Contributor Author

vzakhari commented Sep 5, 2025

@abidh @tblah I think you might have hit the issue that the checks generator script does not fully automate the attributes matching (e.g. for TBAA and debug attributes that Flang generates). Please take a look, and let me know if this change would be useful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banach-space banach-space Awaiting requested review from banach-space

@michaelmaitland michaelmaitland Awaiting requested review from michaelmaitland

@abidh abidh Awaiting requested review from abidh

@tblah tblah Awaiting requested review from tblah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vzakhari