[Headers][X86] Add constexpr support for some AVX[512] intrinsics. #156567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test this locally with the following command:git-clang-format --diff origin/main HEAD --extensions h,c -- clang/lib/Headers/avx512dqintrin.h clang/lib/Headers/avx512vlintrin.h clang/test/CodeGen/X86/avx512dq-builtins.c clang/test/CodeGen/X86/avx512vl-builtins.c
View the diff from clang-format here.diff --git a/clang/lib/Headers/avx512dqintrin.h b/clang/lib/Headers/avx512dqintrin.h
index ee211d3ea..a8435d1cb 100644
--- a/clang/lib/Headers/avx512dqintrin.h
+++ b/clang/lib/Headers/avx512dqintrin.h
@@ -483,8 +483,8 @@ _mm512_maskz_cvtps_epu64 (__mmask8 __U, __m256 __A) {
(__v8di)_mm512_setzero_si512(), \
(__mmask8)(U), (int)(R)))
-static __inline__ __m512d __DEFAULT_FN_ATTRS512_CONSTEXPR
-_mm512_cvtepi64_pd(__m512i __A) {
+static __inline__ __m512d
+ __DEFAULT_FN_ATTRS512_CONSTEXPR _mm512_cvtepi64_pd(__m512i __A) {
return (__m512d)__builtin_convertvector((__v8di)__A, __v8df);
}
@@ -713,8 +713,8 @@ _mm512_maskz_cvttps_epu64 (__mmask8 __U, __m256 __A) {
(__v8di)_mm512_setzero_si512(), \
(__mmask8)(U), (int)(R)))
-static __inline__ __m512d __DEFAULT_FN_ATTRS512_CONSTEXPR
-_mm512_cvtepu64_pd(__m512i __A) {
+static __inline__ __m512d
+ __DEFAULT_FN_ATTRS512_CONSTEXPR _mm512_cvtepu64_pd(__m512i __A) {
return (__m512d)__builtin_convertvector((__v8du)__A, __v8df);
}
|
|
@RKSimon |
No I don't think those are necessary changes tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following AVX[512] intrinsics are now constexpr:
_mm_mask_cvtepi32_pd_mm_maskz_cvtepi32_pd_mm_mask_cvtepi32_ps_mm_maskz_cvtepi32_ps_mm_cvtepu32_pd_mm_mask_cvtepu32_pd_mm_maskz_cvtepu32_pd_mm_cvtepu32_ps_mm_mask_cvtepu32_ps_mm_maskz_cvtepu32_ps_mm256_mask_cvtepi32_pd_mm256_maskz_cvtepi32_pd_mm256_mask_cvtepi32_ps_mm256_maskz_cvtepi32_ps_mm256_cvtepu32_pd_mm256_mask_cvtepu32_pd_mm256_maskz_cvtepu32_pd_mm256_cvtepu32_ps_mm256_mask_cvtepu32_ps_mm256_maskz_cvtepu32_ps_mm512_cvtepi64_pd_mm512_mask_cvtepi64_pd_mm512_maskz_cvtepi64_pd_mm512_cvtepu64_pd_mm512_mask_cvtepu64_pd_mm512_maskz_cvtepu64_pdThis PR is part 2 [part 1] of a series of PRs fixing #155798