[Support] Modernize YAML traits with is_detected (NFC) #156598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modernizes has_* YAML traits with is_detected. The resulting code should be a lot more readable because all the SFINAE logic is hidden behind is_detected. One note about has_FlowTraits. The original code uses a complex trick to detect a member variable named "flow", intentionally triggering ambiguity with "flow" in the two base classes. I've simplified the check down to: template <class U> using check = decltype(&U::flow); without using SameType. The use of SameType here would make the trait unnecessarily complicated. While I am at it, this patch switches to "static constexpr bool".
kuhar
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modernizes has_* YAML traits with is_detected.
The resulting code should be a lot more readable because all the
SFINAE logic is hidden behind is_detected.
One note about has_FlowTraits. The original code uses a complex trick
to detect a member variable named "flow", intentionally triggering
ambiguity with "flow" in the two base classes. I've simplified the
check down to:
template using check = decltype(&U::flow);
without using SameType. The use of SameType here would make the trait
unnecessarily complicated.
While I am at it, this patch switches to "static constexpr bool".