[lld][MachO] Silence warnings about --read-workers parsing #156608
Conversation
The parsing of the --read-workers argument v is implemented like this:
unsigned threads = 0
if (!llvm::to_integer(v, threads, 0) || threads < 0) {
...
As reported by a compiler warning, the value of the "threads < 0"
expession is never going to be true. It could only evaluate to true if
v represents a negative number, but in this case llvm::to_integer
returns false since threads is unsigned and hence the second operand
of the || operator will not be evaluated.
This patch removes the useless || operand to silence compiler
warnings. Since I had to first find out if --read-workers=0 is valid
or not (it seems to be), I also added a test to document the valid
values for the option and I adjusted the error message on invalid
values to clearly state that 0 is valid.
|
@johnno1962 The argument was introduced by your PR #147134, but I couldn't add you as a reviewer. |
|
Thanks for picking this up @frederik-h. If this is giving a warning the code just after it for OPT_threads_eq should be as well as I copied it. Also, while you're changing this code, perhaps the variable name should be "workers" not "threads". |
|
LGTM. |
No, that's fine because
Done. |
|
@drodriguez, @johnno1962 Thank you for the review! |
The parsing of the --read-workers argument v is implemented like this:
unsigned threads = 0
if (!llvm::to_integer(v, threads, 0) || threads < 0) {
...
As reported by a compiler warning, the value of the "threads < 0" expession is never going to be true. It could only evaluate to true if v represents a negative number, but in this case llvm::to_integer returns false since threads is unsigned and hence the second operand of the || operator will not be evaluated.
This patch removes the useless || operand to silence compiler warnings. Since I had to first find out if --read-workers=0 is valid or not (it seems to be), I also added a test to document the valid values for the option and I adjusted the error message on invalid values to clearly state that 0 is valid.