Skip to content

[clang][bytecode] Reject null pointers in CheckStore() #156645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

[clang][bytecode] Reject null pointers in CheckStore() #156645

merged 1 commit into from
Sep 4, 2025

Conversation

tbaederr
Copy link
Contributor

@tbaederr tbaederr commented Sep 3, 2025

In the attached test case, the global variable later only points to gargbage, because the MaterializeTemporaryExpr used to initialize it is a local variable, which is gone by the time we try to evaluate the store.

Fixes #156223

@tbaederr
[clang][bytecode] Reject null pointers in CheckStore()
38da39b 
In the attached test case, the global variable later only points to
gargbage, because the MaterializeTemporaryExpr used to initialize it is
a local variable, which is gone by the time we try to evaluate the
store.

Fixes llvm#156223
@tbaederr tbaederr added clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:bytecode Issues for the clang bytecode constexpr interpreter labels Sep 3, 2025
@tbaederr tbaederr merged commit 4931c3a into llvm:main Sep 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clang:bytecode Issues for the clang bytecode constexpr interpreter clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[clang][bytecode] crash on thread_local
1 participant
@tbaederr