[mlir][IR] Fix enum attribute handling by using parseKeywordOrString instead of parseKeyword #156662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Mora <fabian.mora-cordero@amd.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes enum attribute parsing in MLIR to handle special characters and multi-word identifiers by replacing parseKeyword with parseKeywordOrString. This change allows enum values to use symbols like "+" and strings with separators like "dash-separated-sentence" instead of being limited to valid identifiers, aligning with how enums are handled by the FieldParser.
Key changes:
- Updated enum attribute parsing from
parseKeywordtoparseKeywordOrString - Added test coverage for enum values with special characters and multi-word identifiers
- Enhanced existing test enums to include these new capabilities
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mlir/include/mlir/IR/EnumAttr.td | Updated parsing logic for IntEnumAttr and BitEnumAttr to use parseKeywordOrString |
| mlir/test/mlir-tblgen/attr-or-type-format.td | Added new test enum with special character cases and updated existing enum |
| mlir/test/mlir-tblgen/attr-or-type-format-roundtrip.mlir | Added roundtrip tests for special character enum values |
| mlir/test/lib/Dialect/Test/TestEnumDefs.td | Extended TestSimpleEnum with special character cases |
| mlir/test/IR/array-of-attr.mlir | Updated test to include special character enum value in array |
zero9178
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change enum attribute parsing to handle special characters and multi-word
identifiers. This allows enum attrs to use symbols like "+" and strings
with separators like "dash-separated-sentence" instead of being limited to
valid identifiers.
This also aligns enum attribute parsing with how enums are already handled
by the
FieldParser:https://github.com/llvm/llvm-project/blob/main/mlir/tools/mlir-tblgen/EnumsGen.cpp#L108