[Offload] Run unit tests as a part of check-offload #156675
Conversation
Summary: Add a dependnecy on the unit tests on the main check-offload test suite. This matches what the other projects do, pass `llvm-lit` to the directory to only run the lit tests, use the `check-offload-unit` for only the unit tests.
|
@llvm/pr-subscribers-offload Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/156675.diff 1 Files Affected:
diff --git a/offload/test/CMakeLists.txt b/offload/test/CMakeLists.txt
index 711621de9075d..c317394ada66f 100644
--- a/offload/test/CMakeLists.txt
+++ b/offload/test/CMakeLists.txt
@@ -61,7 +61,7 @@ add_offload_testsuite(check-offload
"Running libomptarget tests"
${LIBOMPTARGET_LIT_TESTSUITES}
EXCLUDE_FROM_CHECK_ALL
- DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS}
+ DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS} check-offload-unit
ARGS ${LIBOMPTARGET_LIT_ARG_LIST})
# Add liboffload unit tests - the test binary will run on all available devices
|
|
It appears that this breaks the ability to do Leaving this here as an observation and something we likely want to fix at some point. |
Hm, maybe the other targets do something slightly different to register their unit tests. Right now we just do |
Summary:
Add a dependnecy on the unit tests on the main check-offload test suite.
This matches what the other projects do, pass
llvm-litto thedirectory to only run the lit tests, use the
check-offload-unitforonly the unit tests.