Skip to content

Conversation

mizvekov
Copy link
Contributor

@mizvekov mizvekov commented Sep 4, 2025

Honor LLVM_OPTIMIZED_TABLEGEN when LLVM_USE_SANITIZER is used.

@@ -666,7 +666,7 @@ if(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD STREQUAL "all")
set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD ${LLVM_ALL_EXPERIMENTAL_TARGETS})
endif()

if("flang" IN_LIST LLVM_ENABLE_PROJECTS AND
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's submit this NFC separately

Copy link
Collaborator

@vitalybuka vitalybuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's with LLVM_OPTIMIZED_TABLEGEN only, then LGTM

We still want to be able to sanitize TABLEGEN as well

@fmayer
Copy link
Contributor

fmayer commented Sep 4, 2025

If it's with LLVM_OPTIMIZED_TABLEGEN only, then LGTM

We still want to be able to sanitize TABLEGEN as well

I realized the commit message makes it easy to confuse this. Please change to something like "respect LLVM_OPTIMIZED_TABLEGEN for sanitizers".

Honor LLVM_OPTIMIZED_TABLEGEN when LLVM_USE_SANITIZER is used.
@mizvekov mizvekov force-pushed the users/mizvekov/opt-tablegen-sanitizer branch from 517b34c to ed4bb1f Compare September 4, 2025 18:35
@mizvekov mizvekov merged commit 829ddbe into main Sep 4, 2025
9 checks passed
@mizvekov mizvekov deleted the users/mizvekov/opt-tablegen-sanitizer branch September 4, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants