[AMX] Fix LIT test with adjustsStack attribute for expensive checks build. #156808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild. The generated MIR fails machine verifier as stack pointer is being modified without appropriate attributes in frameInfo. This PR fixes this issue by adding adjustsStack=true attribute. Fixes the post commit regression identified in llvm#155673.
|
@llvm/pr-subscribers-backend-x86 Author: Karthik Senthil (karthik-senthil) ChangesThe generated MIR fails machine verifier as stack pointer is being modified without appropriate attributes in frameInfo. This PR fixes this issue by adding adjustsStack=true attribute. Fixes the post commit regression identified in #155673. Full diff: https://github.com/llvm/llvm-project/pull/156808.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/X86/AMX/amx-sink-config-after-calls.mir b/llvm/test/CodeGen/X86/AMX/amx-sink-config-after-calls.mir
index b76faf6cbb88b..82049dce8a45c 100644
--- a/llvm/test/CodeGen/X86/AMX/amx-sink-config-after-calls.mir
+++ b/llvm/test/CodeGen/X86/AMX/amx-sink-config-after-calls.mir
@@ -1,5 +1,5 @@
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
-# RUN: llc -mtriple=x86_64-- -mattr=+amx-int8,avx512f -run-pass="fastpretileconfig,regallocfast,fasttileconfig" -o - %s | FileCheck %s
+# RUN: llc -mtriple=x86_64-- -mattr=+amx-int8,avx512f -run-pass="fastpretileconfig,regallocfast,fasttileconfig" -verify-machineinstrs -o - %s | FileCheck %s
# Test to verify that ldtilecfg instructions are sinked closer to tile defining
# instructions after a call. This ensures call does not overwrite values in
@@ -43,6 +43,7 @@ liveins:
- { reg: '$rdi', virtual-reg: '%0' }
- { reg: '$rsi', virtual-reg: '%2' }
frameInfo:
+ adjustsStack: true
maxAlignment: 1024
stack:
- { id: 0, size: 1024, alignment: 1024 }
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/26687 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated MIR fails machine verifier as stack pointer is being modified without appropriate attributes in frameInfo. This PR fixes this issue by adding adjustsStack=true attribute. Fixes the post commit regression identified in #155673.