Skip to content

Conversation

correctmost
Copy link

References to -Wimplicit-int-comparison-on-negation should be -Wimplicit-int-conversion-on-negation instead.

See: https://github.com/llvm/llvm-project/pull/139429/files#r2124372667

Copy link

github-actions bot commented Sep 4, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 4, 2025

@llvm/pr-subscribers-clang

Author: None (correctmost)

Changes

References to -Wimplicit-int-comparison-on-negation should be -Wimplicit-int-conversion-on-negation instead.

See: https://github.com/llvm/llvm-project/pull/139429/files#r2124372667


Full diff: https://github.com/llvm/llvm-project/pull/156815.diff

1 Files Affected:

  • (modified) clang/docs/ReleaseNotes.rst (+2-2)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 9400be296e7c2..f03a3273c4518 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -677,8 +677,8 @@ Improvements to Clang's diagnostics
   trigger a ``'Blue' is deprecated`` warning, which can be turned off with
   ``-Wno-deprecated-declarations-switch-case``.
 
-- Split diagnosis of implicit integer comparison on negation to a new
-  diagnostic group ``-Wimplicit-int-comparison-on-negation``, grouped under
+- Split diagnosis of implicit integer conversion on negation to a new
+  diagnostic group ``-Wimplicit-int-conversion-on-negation``, grouped under
   ``-Wimplicit-int-conversion``, so user can turn it off independently.
 
 - Improved the FixIts for unused lambda captures.

Copy link

github-actions bot commented Sep 4, 2025

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Developer Policy and LLVM Discourse for more information.

References to -Wimplicit-int-comparison-on-negation should be
-Wimplicit-int-conversion-on-negation instead.
@correctmost correctmost force-pushed the int-comparison-rel-notes branch from 37a8b8c to b960876 Compare September 4, 2025 17:15
@correctmost
Copy link
Author

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.

Fixed with a force push

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Merge in LLVM Release Status Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
Status: Needs Merge
Development

Successfully merging this pull request may close these issues.

4 participants