[compiler-rt][ASan] Work around msvc cl x64 build warnings #156887
Conversation
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Zack Johnson (zacklj89) ChangesAfter #154694, MSVC cl started emitting build warnings for 64 bit architectures
This documentation is being updated for clarity, but the Full diff: https://github.com/llvm/llvm-project/pull/156887.diff 1 Files Affected:
diff --git a/compiler-rt/lib/asan/CMakeLists.txt b/compiler-rt/lib/asan/CMakeLists.txt
index 7d07ec765c005..459581fd0cff3 100644
--- a/compiler-rt/lib/asan/CMakeLists.txt
+++ b/compiler-rt/lib/asan/CMakeLists.txt
@@ -108,7 +108,8 @@ set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
# Win/ASan relies on the runtime functions being hotpatchable. See
# https://github.com/llvm/llvm-project/pull/149444
-if(MSVC)
+# MSVC cl 64 bit architectures treat /hotpatch as an unknown option
+if(CLANG_CL OR (MSVC AND "i386" IN_LIST ASAN_SUPPORTED_ARCH))
list(APPEND ASAN_CFLAGS /hotpatch)
endif()
|
| @@ -108,7 +108,8 @@ set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS}) | |||
|
|
|||
| # Win/ASan relies on the runtime functions being hotpatchable. See | |||
| # https://github.com/llvm/llvm-project/pull/149444 | |||
| if(MSVC) | |||
| # MSVC cl 64 bit architectures treat /hotpatch as an unknown option | |||
| if(CLANG_CL OR (MSVC AND "i386" IN_LIST ASAN_SUPPORTED_ARCH)) | |||
There was a problem hiding this comment.
Unfortunately, it doesn't seem like the CLANG_CL check actually works; at least not in the "runtimes build" (-DLLVM_ENABLE_RUNTIMES=compiler-rt). For example, I'm getting warnings about the /experimental: flags (line 124) when building with clang-cl.
It would be great if someone fixed that of course :-)
There was a problem hiding this comment.
Oh no 😃 thanks for pointing that out!
I'll look into what it would take to get that online. In the meantime, I'll mark this back as a draft.
There was a problem hiding this comment.
CLANG_CL is also used a few lines down to silence some other warnings related to MSVC. I'm wondering if I have something locally that is precluding me from seeing the same issues you are.
There was a problem hiding this comment.
Those are the ones I meant:
llvm-project/compiler-rt/lib/asan/CMakeLists.txt
Lines 121 to 124 in b2ff3e7
I don't think they work, i.e. the /experimental:external flags get passed also when using clang-cl, and cause warnings, e.g. from https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8704672462688910449/+/u/package_clang/stdout
[112/349] Building CXX object compiler-rt\lib\asan\CMakeFiles\RTAsan_dynamic.x86_64.dir\asan_debugging.cpp.obj
clang-cl: warning: argument unused during compilation: '/experimental:external' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '/external:anglebrackets' [-Wunused-command-line-argument]
I think maybe the CLANG_CL check used to work when building with -DLLVM_ENABLE_PROJECTS=compiler-rt but not in the new "runtimes build" using -DLLVM_ENABLE_RUNTIMES=compiler-rt but that's just me speculating.
There was a problem hiding this comment.
It would help if I could read 🤣
Ok, thanks for the clue into where to check!
There was a problem hiding this comment.
Related to this, I left a comment on this thread about "runtime build" issues: #58568
After #154694, MSVC cl started emitting build warnings for 64 bit architectures
cl : Command line warning D9002 : ignoring unknown option '/hotpatch'This documentation is being updated for clarity, but the
/hotpatchcompiler option only affects x86 compilation.