[MLIR] Make the pass_thru argument of llvm masked.load intrinsic Optional instead of Variadic #156917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal instead of Variadic This is meant as NFC as multiple values there was never supported anyway. Extra values would be dropped when translating to LLVM IR.
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir Author: Mehdi Amini (joker-eph) ChangesThis is meant as NFC as multiple values there was never supported anyway. Extra values would be dropped when translating to LLVM IR. Full diff: https://github.com/llvm/llvm-project/pull/156917.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
index fa2e10c9cdee5..dd00d67974d28 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
@@ -1000,17 +1000,17 @@ def LLVM_GetActiveLaneMaskOp
/// Create a call to Masked Load intrinsic.
def LLVM_MaskedLoadOp : LLVM_OneResultIntrOp<"masked.load"> {
let arguments = (ins LLVM_AnyPointer:$data, LLVM_VectorOf<I1>:$mask,
- Variadic<LLVM_AnyVector>:$pass_thru, I32Attr:$alignment,
+ Optional<LLVM_AnyVector>:$pass_thru, I32Attr:$alignment,
UnitAttr:$nontemporal);
let results = (outs LLVM_AnyVector:$res);
let assemblyFormat =
"operands attr-dict `:` functional-type(operands, results)";
string llvmBuilder = [{
- auto *inst = $pass_thru.empty() ? builder.CreateMaskedLoad(
- $_resultType, $data, llvm::Align($alignment), $mask) :
+ auto *inst = $pass_thru ? builder.CreateMaskedLoad(
+ $_resultType, $data, llvm::Align($alignment), $mask, $pass_thru) :
builder.CreateMaskedLoad(
- $_resultType, $data, llvm::Align($alignment), $mask, $pass_thru[0]);
+ $_resultType, $data, llvm::Align($alignment), $mask);
$res = inst;
}] #setNonTemporalMetadataCode;
string mlirBuilder = [{
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as NFC as multiple values there was never supported anyway. Extra values would be dropped when translating to LLVM IR.