[clang] Add [system] label to modules from resource headers #156934
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Cyndy Ishida (cyndyishida) ChangesSince resource headers are installed, commonly as system dependencies, they should have Full diff: https://github.com/llvm/llvm-project/pull/156934.diff 1 Files Affected:
diff --git a/clang/lib/Headers/module.modulemap b/clang/lib/Headers/module.modulemap
index a72828625a629..bdf5119ba4607 100644
--- a/clang/lib/Headers/module.modulemap
+++ b/clang/lib/Headers/module.modulemap
@@ -329,13 +329,13 @@ module _Builtin_unwind [system] {
}
// End -fbuiltin-headers-in-system-modules affected modules
-module opencl_c {
+module opencl_c [system] {
requires opencl
header "opencl-c.h"
header "opencl-c-base.h"
}
-module ptrauth {
+module ptrauth [system] {
header "ptrauth.h"
export *
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since resource headers are installed, commonly as system dependencies, they should have
[system]on them. Fix up the ones missing.