[LLDB] Fix deterministic-build.cpp post #156931 #156983
Conversation
This test was brokem by migrating to the lit internal shell due to a lack of env prefix for setting environment variables. This was fixed in prevented the breakpoint in the test from mapping to anything, causing the test to file. This patch restores the original line numbering.
|
@llvm/pr-subscribers-lldb Author: Aiden Grossman (boomanaiden154) ChangesThis test was brokem by migrating to the lit internal shell due to a lack of env prefix for setting environment variables. This was fixed in prevented the breakpoint in the test from mapping to anything, causing the test to file. This patch restores the original line numbering. Full diff: https://github.com/llvm/llvm-project/pull/156983.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/deterministic-build.cpp b/lldb/test/Shell/SymbolFile/DWARF/deterministic-build.cpp
index 13fe3898e50aa..a45f794c73a43 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/deterministic-build.cpp
+++ b/lldb/test/Shell/SymbolFile/DWARF/deterministic-build.cpp
@@ -7,4 +7,5 @@
// RUN: %lldb %t -o "breakpoint set -f %s -l 11" -o run -o exit | FileCheck %s
// CHECK: stop reason = breakpoint
+
int main() { return 0; }
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Just FYI: That blank line got removed because otherwise it failed the code formatting premerge test. :-( |
Good point. Updated to change the line number rather than add in the extra blank line. I've confirmed this fixes the issue locally, so I'm going to merge this once upstream premerge CI passes to try and get the bots back to green. |
This test was brokem by migrating to the lit internal shell due to a lack of env prefix for setting environment variables. This was fixed in prevented the breakpoint in the test from mapping to anything, causing the test to file. This patch restores the original line numbering.