AMDGPU: Fix using unaligned vgprs in mimg error test #157001
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These instructions really have 2 errors, from the unsupported image base instruction plus the unaligned vgpr usage. This test intends to test the base instruction error, so fix the secondary error to avoid changing the diagnostic in a future patch.
|
@llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesThese instructions really have 2 errors, from the unsupported Full diff: https://github.com/llvm/llvm-project/pull/157001.diff 1 Files Affected:
diff --git a/llvm/test/MC/AMDGPU/mimg-err.s b/llvm/test/MC/AMDGPU/mimg-err.s
index bec33bab984ab..63a5757f2a1b5 100644
--- a/llvm/test/MC/AMDGPU/mimg-err.s
+++ b/llvm/test/MC/AMDGPU/mimg-err.s
@@ -12,22 +12,22 @@ image_load v[4:6], v[237:240], s[28:35] dmask:0x7 tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: invalid operand for instruction
-image_load v[4:5], v[237:240], s[28:35] dmask:0x7
+image_load v[4:5], v[236:239], s[28:35] dmask:0x7
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: image data size does not match dmask and d16
-image_store v[4:7], v[237:240], s[28:35] dmask:0x7
+image_store v[4:7], v[236:239], s[28:35] dmask:0x7
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: image data size does not match dmask and d16
-image_store v[4:7], v[237:240], s[28:35] dmask:0xe
+image_store v[4:7], v[236:239], s[28:35] dmask:0xe
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: image data size does not match dmask and d16
-image_load v4, v[237:240], s[28:35] tfe
+image_load v4, v[236:239], s[28:35] tfe
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: invalid operand for instruction
@@ -36,17 +36,17 @@ image_load v4, v[237:240], s[28:35] tfe
// Image Sample
//===----------------------------------------------------------------------===//
-image_sample v[193:195], v[237:240], s[28:35], s[4:7] dmask:0x7 tfe
+image_sample v[192:194], v[236:239], s[28:35], s[4:7] dmask:0x7 tfe
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: invalid operand for instruction
-image_sample v[193:195], v[237:240], s[28:35], s[4:7] dmask:0x3
+image_sample v[192:194], v[236:239], s[28:35], s[4:7] dmask:0x3
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: image data size does not match dmask and d16
-image_sample v[193:195], v[237:240], s[28:35], s[4:7] dmask:0xf
+image_sample v[192:194], v[236:239], s[28:35], s[4:7] dmask:0xf
// NOGCN: error: image data size does not match dmask and tfe
// NOGFX9: error: image data size does not match dmask, d16 and tfe
// NOGFX90A: :[[@LINE-3]]:{{[0-9]+}}: error: image data size does not match dmask and d16
|
rampitec
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These instructions really have 2 errors, from the unsupported
image base instruction plus the unaligned vgpr usage. This
test intends to test the base instruction error, so fix the
secondary error to avoid changing the diagnostic in a future
patch.