[mlir][Transforms][NFC] Improve dialect conversion documentation #94736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesFull diff: https://github.com/llvm/llvm-project/pull/94736.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 83198c9b0db54..f6c51499f271c 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -1088,8 +1088,9 @@ struct ConversionConfig {
/// An optional listener that is notified about all IR modifications in case
/// dialect conversion succeeds. If the dialect conversion fails and no IR
- /// modifications are visible (i.e., they were all rolled back), no
- /// notifications are sent.
+ /// modifications are visible (i.e., they were all rolled back), or if the
+ /// dialect conversion is an "analysis conversion", no notifications are
+ /// sent (apart from `notifyPatternBegin`/notifyPatternEnd`).
///
/// Note: Notifications are sent in a delayed fashion, when the dialect
/// conversion is guaranteed to succeed. At that point, some IR modifications
|
joker-eph
approved these changes
Jun 8, 2024
nekoshirro
pushed a commit
to nekoshirro/Alchemist-LLVM
that referenced
this pull request
Jun 9, 2024
…m#94736) Signed-off-by: Hafidz Muzakky <ais.muzakky@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.