[libc++] Update some C++23 statuses to "Nothing to do" or "Complete" #99621
Conversation
[P2160R1][] "Locks lock lockables" is a paper that updates wording, without changing behaviour. [P2160R1]: https://wg21.link/p2160r1
|
@llvm/pr-subscribers-libcxx Author: nicole mazzuca (strega-nil) ChangesP2160R1 "Locks lock lockables" is a paper that updates wording, without changing behaviour. Full diff: https://github.com/llvm/llvm-project/pull/99621.diff 1 Files Affected:
diff --git a/libcxx/docs/Status/Cxx23Papers.csv b/libcxx/docs/Status/Cxx23Papers.csv
index 6dd6bdad07658..42a10ae85e816 100644
--- a/libcxx/docs/Status/Cxx23Papers.csv
+++ b/libcxx/docs/Status/Cxx23Papers.csv
@@ -6,7 +6,7 @@
"","","","","","",""
"`P1682R3 <https://wg21.link/P1682R3>`__","LWG","std::to_underlying for enumerations","February 2021","|Complete|","13.0"
"`P2017R1 <https://wg21.link/P2017R1>`__","LWG","Conditionally borrowed ranges","February 2021","|Complete|","16.0","|ranges|"
-"`P2160R1 <https://wg21.link/P2160R1>`__","LWG","Locks lock lockables","February 2021","",""
+"`P2160R1 <https://wg21.link/P2160R1>`__","LWG","Locks lock lockables","February 2021","Nothing to do",""
"`P2162R2 <https://wg21.link/P2162R2>`__","LWG","Inheriting from std::variant","February 2021","|Complete|","13.0"
"`P2212R2 <https://wg21.link/P2212R2>`__","LWG","Relax Requirements for time_point::clock","February 2021","",""
"`P2259R1 <https://wg21.link/P2259R1>`__","LWG","Repairing input range adaptors and counted_iterator","February 2021","","","|ranges|"
|
libcxx/docs/Status/Cxx23Papers.csv
Outdated
| @@ -120,4 +120,4 @@ | |||
| "`P2614R2 <https://wg21.link/P2614R2>`__","LWG", "Deprecate ``numeric_limits::has_denorm``","February 2023","|Complete|","18.0","" | |||
| "`P2588R3 <https://wg21.link/P2588R3>`__","LWG", "``barrier``’s phase completion guarantees","February 2023","","","" | |||
| "`P2763R1 <https://wg21.link/P2763R1>`__","LWG", "``layout_stride`` static extents default constructor fix","February 2023","","","" | |||
| "`P2736R2 <https://wg21.link/P2736R2>`__","CWG","Referencing The Unicode Standard","February 2023","","","|format|" | |||
| "`P2736R2 <https://wg21.link/P2736R2>`__","CWG","Referencing The Unicode Standard","February 2023","Nothing to do","","|format|" | |||
There was a problem hiding this comment.
I would say no; the paper involved is not updating the unicode standard, just switching to referencing the unicode standard rather than ISO 10646.
There was a problem hiding this comment.
Hmm, the referenced Unicode version used by <format> seemed to be Unicode 14 (per Bibliography in the paper) , and the paper updated the referenced version to 15?
There was a problem hiding this comment.
This paper, in my opinion, just removes the referenced version - the current C++ standard only refers to the latest unicode standard, unversioned. In my opinion, this means that implementations are free to reference any standard (perhaps only newer than the C++ standard they are implementing), and therefore that updating the standard referenced in implementations is just an implementation detail.
There was a problem hiding this comment.
Actually it means implementations should always use the latest released Unicode version. This means it's complete until the next Unicode release. I think marking it as complete in version 19.0 would be better.
There is a core issue filed against this change.
There was a problem hiding this comment.
Mmh, point; I'll make this change, thanks @mordante!
libcxx/docs/Status/Cxx23Papers.csv
Outdated
| @@ -120,4 +120,4 @@ | |||
| "`P2614R2 <https://wg21.link/P2614R2>`__","LWG", "Deprecate ``numeric_limits::has_denorm``","February 2023","|Complete|","18.0","" | |||
| "`P2588R3 <https://wg21.link/P2588R3>`__","LWG", "``barrier``’s phase completion guarantees","February 2023","","","" | |||
| "`P2763R1 <https://wg21.link/P2763R1>`__","LWG", "``layout_stride`` static extents default constructor fix","February 2023","","","" | |||
| "`P2736R2 <https://wg21.link/P2736R2>`__","CWG","Referencing The Unicode Standard","February 2023","","","|format|" | |||
| "`P2736R2 <https://wg21.link/P2736R2>`__","CWG","Referencing The Unicode Standard","February 2023","Nothing to do","","|format|" | |||
There was a problem hiding this comment.
Actually it means implementations should always use the latest released Unicode version. This means it's complete until the next Unicode release. I think marking it as complete in version 19.0 would be better.
There is a core issue filed against this change.
…99621) Summary: - [P2160R1][] "Locks lock lockables" - [P2212R2][] "Relax Requirements for `time_point::clock`" - [P1675R2][] "`rethrow_exception` must be allowed to copy" - [P2340R1][] "Clarifying the status of the 'C headers'" - [P2460R2][] "Relax requirements on `wchar_t` to match existing practices" Are all papers that change wording without changing implementation behaviour. Additionally, [P2736R2][] "Referencing The Unicode Standard", is an already complete paper in 19.0 (as of [LLVM-86543][]) [P2160R1]: https://wg21.link/p2160r1 [P2212R2]: https://wg21.link/p2212r2 [P1675R2]: https://wg21.link/p1675r2 [P2340R1]: https://wg21.link/p2340r1 [P2460R2]: https://wg21.link/p2460r2 [P2736R2]: https://wg21.link/p2736r2 [LLVM-86543]: #86543 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251122
time_point::clock"rethrow_exceptionmust be allowed to copy"wchar_tto match existing practices"Are all papers that change wording without changing implementation behaviour.
Additionally, P2736R2 "Referencing The Unicode Standard", is an already complete paper in 19.0 (as of LLVM-86543)