Skip to content

[HIP] add test split-kernel-args #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

[HIP] add test split-kernel-args #230

merged 1 commit into from
Apr 23, 2025

Conversation

yxsamliu
Copy link
Contributor

@yxsamliu yxsamliu commented Apr 9, 2025

Add a test split-kernel-args.hip for testing AMDGPUSplitKernelArguments pass, which splits byref struct-type kernel arguments so that they can be preloaded for better performance.

This test checks struct-type kearnel arguments are passed correctly.

@yxsamliu yxsamliu requested review from arsenm, Artem-B and jplehr April 9, 2025 02:14
@yxsamliu yxsamliu mentioned this pull request Apr 9, 2025
Open
jplehr
jplehr approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@jplehr jplehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the CMake etc look good. Test itself seems fine to me.
Probably should land only after the corresponding LLVM patch has landed.

@yxsamliu yxsamliu force-pushed the add-split-kernel-args branch from bd4bdc5 to fb0a03f Compare April 23, 2025 00:57
@yxsamliu
Copy link
Contributor Author

Changes to the CMake etc look good. Test itself seems fine to me. Probably should land only after the corresponding LLVM patch has landed.

Yes will only land it after the corresponding LLVM patch being landed.

@arsenm
Copy link

arsenm commented Apr 23, 2025

Changes to the CMake etc look good. Test itself seems fine to me. Probably should land only after the corresponding LLVM patch has landed.

Yes will only land it after the corresponding LLVM patch being landed.

You can land it before without the flag to enable the pass added

@yxsamliu
Copy link
Contributor Author

Changes to the CMake etc look good. Test itself seems fine to me. Probably should land only after the corresponding LLVM patch has landed.

Yes will only land it after the corresponding LLVM patch being landed.

You can land it before without the flag to enable the pass added

will do

@yxsamliu
[HIP] add test split-kernel-args
eb9d1c7 
Add a test split-kernel-args.hip for testing AMDGPUSplitKernelArguments
pass, which splits byref struct-type kernel arguments so that they
can be preloaded for better performance.

This test checks struct-type kearnel arguments are passed correctly.
@yxsamliu yxsamliu force-pushed the add-split-kernel-args branch from fb0a03f to eb9d1c7 Compare April 23, 2025 15:56
@yxsamliu yxsamliu merged commit be7a9dc into llvm:main Apr 23, 2025
1 check passed
@yxsamliu yxsamliu mentioned this pull request Apr 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artem-B Artem-B Artem-B left review comments

@jplehr jplehr jplehr approved these changes

@arsenm arsenm Awaiting requested review from arsenm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yxsamliu @arsenm @Artem-B @jplehr