[Fortran] disable pointer_check_11.f90 which exhibits UB #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test calls an empty subroutine with a null pointer as an argument. In gfortran it is hoped that a flag will detect this and produce an error. Flang does not perform any such analysis, and so on some machines when optimization is enabled, this test never terminates. I don't think this is a flang bug as such because the input code is doing undefined behaviour.
|
I can confirm this is happening. Built with -O0 (which is the default for the Debug build of this test suite), this program crashes as expected. Built with -O3 (which is the default for the Release build) it spins forever until is hit by the 2h timeout (and this is reported as passing successfully after all!). Since this is UB, all bets are off, and compiler is allowed to do whatever when optimizing it at -O3, so one can't claim it as incorrect compiler's behavior. |
pawosm-arm
approved these changes
Apr 15, 2025
tarunprabhu
approved these changes
Apr 15, 2025
|
Could you consider cherry-picking it to the release/20.x branch? |
|
/cherry-pick 0bbf038 |
tblah
added a commit
to tblah/llvm-test-suite
that referenced
this pull request
Apr 15, 2025
This test calls an empty subroutine with a null pointer as an argument. In gfortran it is hoped that a flag will detect this and produce an error. Flang does not perform any such analysis, and so on some machines when optimization is enabled, this test never terminates. I don't think this is a flang bug as such because the input code is doing undefined behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test calls an empty subroutine with a null pointer as an argument. In gfortran it is hoped that a flag will detect this and produce an error. Flang does not perform any such analysis, and so on some machines when optimization is enabled, this test never terminates. I don't think this is a flang bug as such because the input code is doing undefined behavior.