Skip to content

[Fortran/gfortran] Sync gfortran tests with upstream #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tarunprabhu
Copy link
Contributor

@tarunprabhu tarunprabhu commented May 6, 2025

These are synced with c182f4d14d65b3e012.

Any new tests that fail have been added to the appropriate deny lists. The reasons for these failures have not been thoroughly investigated though, so some recategorization may be necessary.

Some bugs in the build system for the tests was uncovered in the process and fixed.


Notes for reviewers: Only the following files need to be reviewed:

The tests.cmake files are generated by the update-test-config script. The source code files and .exp files are exactly the same as those upstream. None of these files need to be reviewed.

I have solicited reviews from a larger number of reviewers so the test suite can be tested on a wider range of platforms.

These are synced with c182f4d14d65b3e012.

Any new tests that fail have been added to the appropriate deny lists. The
reasons for these failures have not been thoroughly investigated though, so
some recategorization may be necessary.

Some bugs in the build system for the tests was uncovered in the process and
fixed.
@tarunprabhu tarunprabhu marked this pull request as ready for review May 7, 2025 00:15
@tblah
Copy link
Contributor

tblah commented May 7, 2025

Fortran/gfortran/regression/pr117797.f90 fails for me at -O0 (STOP 2) but passes at -O1 and above.

@tarunprabhu
Copy link
Contributor Author

Thanks Tom. The test failed for me when I switched to a Debug build of the test suite on X86 as well. It has been disabled.

@ylzsx
Copy link
Contributor

ylzsx commented May 8, 2025

Thanks. The same test pr117797.f90 on a LoongArch 3A5000 machine also fails at -O0 (Fortran STOP: code 2) but passes at -O1 and above. However, when -flto=auto is enabled, the error reappears.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this all passes for me on aarch64

Copy link
Contributor

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the gfortran tests. No failures on my AArch64 machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants