Skip to content

Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2020
Merged

Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method #100

merged 2 commits into from
Apr 15, 2020

Conversation

svegaxmr
Copy link
Contributor

necessary for code like mdb_cursor_get(m_cur_block_heights, (MDB_val *)&zerokval, &val_h, MDB_GET_BOTH)

@benalexau
Copy link
Member

Thanks for this PR. Would you mind please providing a corresponding test case?

@benalexau benalexau added enhancement Additional or new functionality awaiting-response labels Dec 9, 2018
@svegaxmr
Copy link
Contributor Author

What is the highest version of Java that the tests can target?

@codecov-io
Copy link

codecov-io commented Jan 25, 2019 •
edited
Loading

Codecov Report

Merging #100 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     90.98%   91.04%   +0.05%     
+ Complexity      373      352      -21     
============================================
  Files            29       28       -1     
  Lines          1265     1172      -93     
  Branches        113      106       -7     
============================================
- Hits           1151     1067      -84     
+ Misses           48       45       -3     
+ Partials         66       60       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/lmdbjava/Cursor.java 80% <0%> (-10%) 25 <0> (ø)
src/main/java/org/lmdbjava/Verifier.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a927565...7a70355. Read the comment docs.

@benalexau benalexau force-pushed the master branch 11 times, most recently from 8809f8e to fed0c5d Compare April 15, 2020 05:03
benalexau added a commit that referenced this pull request Apr 15, 2020
@benalexau
Add test for PR #100
a781bb2
@benalexau benalexau merged commit e5f5008 into lmdbjava:master Apr 15, 2020
@benalexau benalexau changed the title add cursor seek for MDB_GET_BOTH Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method Apr 15, 2020
@benalexau
Copy link
Member

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Additional or new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svegaxmr @benalexau @codecov-io @Sylvyrfysh