Skip to content

Hold strong reference to all buffers passed to LmdbJava (fixes #207) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Hold strong reference to all buffers passed to LmdbJava (fixes #207) #214

merged 1 commit into from
Apr 24, 2023
+187 −0

Conversation

2018ik
Copy link
Contributor

@2018ik 2018ik commented Mar 23, 2023

See repro steps: #207 (comment)

With this change, I don't see the issue anymore. Doesn't rely on reachabilityFence since that is JDK 9+

@2018ik 2018ik mentioned this pull request Mar 23, 2023
Closed
@2018ik 2018ik force-pushed the fixcorruptionbug branch from e798bb0 to d01270b Compare April 21, 2023 22:38
@2018ik 2018ik force-pushed the fixcorruptionbug branch from d01270b to 0c636f1 Compare April 21, 2023 22:39
@benalexau benalexau merged commit c5e02f7 into lmdbjava:master Apr 24, 2023
@benalexau
Copy link
Member

Thanks @2018ik, I have merged this.

I made some adjustments and commented in related commit cbdaee6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2018ik @benalexau