Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

Conversation

Karm
Copy link

@Karm Karm commented Sep 25, 2020

This PR surpasses and completes #7 , which can be closed.

@Karm
Copy link
Author

Karm commented Oct 23, 2020

?

@benalexau
Copy link
Member

Thanks @Karm for this PR. Please accept my apologies for the delay in reviewing it (and its predecessor #7).

At present we use GitHub Actions to compile or cross-compile the LMDB native library for all architectures defined in the LmdbJava Native Parent POM. Maintaining automatic, reproducible builds with public build logs is a priority given it significantly simplifies long-term maintenance of the LmdbJava project while also offering everyone reassurance as to the test suite verification and binary contents of JARs automatically deployed to Maven Central.

Given the benefits of using GitHub Actions to build and compile the native libraries, I wonder whether you might be able to comment on the viability of a cross-compilation option? I did a quick search and found several GitHub Actions YAML files which are using various cross-compilation approaches for aarch64 and ppc64le. There is also a GitHub Action called run-on-arch-action which is currently targeting five platforms including aarch64 and ppc64le.

If you could offer some comments on this I would appreciate it.

@benalexau
Copy link
Member

I added an extra operating system (Arch Linux) to several run-on-arch-action platforms and started using it in another project. I believe run-on-arch-action is the preferred way to add additional platform / OS combinations. I will take a closer look at this when I get some free cycles.

@benalexau
Copy link
Member

Closing this ticket as lmdbjava/lmdbjava#217 has provided a Zig-based cross-compilation in the Java module product. This in turn means the LmdbJava Native project is no longer required and will be archived.

I welcome contributions in the LmdbJava project if you wish to revisit this based on the new Zig-based cross-compiled builds (which include ARM targets).

@benalexau benalexau closed this Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants