Skip to content

add APIGW NextGen doc #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2024
Merged

add APIGW NextGen doc #1505

merged 3 commits into from
Oct 3, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 30, 2024 •
edited by cloutierMat
Loading

This PR adds documentation about the NextGen API provider. Community provider work can be seen here: localstack/localstack#11035

TODO

  • update the link to 3.8.0

@bentsku bentsku self-assigned this Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1505.surge.sh 🎊

@bentsku bentsku requested a review from HarshCasper September 30, 2024 23:09
cloutierMat
cloutierMat approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

I think you cover all of the important points! So much work described in a few sentences.

We should update the link to the configuration page to point to the right section of the doc. But other that that! 👍

content/en/user-guide/aws/apigateway/index.md Outdated

Since [3.8.0](link here), LocalStack supports a new API Gateway implementation for both API Gateway v1 (REST API) and v2 (HTTP API).

You can [set the following flag]({{< ref "configuration" >}}) `PROVIDER_OVERRIDE_APIGATEWAY=next_gen` to use the new implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do {{< ref "configuration#api-gateway" >}} to link to the right section of the doc.

content/en/user-guide/aws/apigateway/index.md

{{< callout >}}

Since [3.8.0](link here), LocalStack supports a new API Gateway implementation for both API Gateway v1 (REST API) and v2 (HTTP API).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to not forget to update this link before merging. I also added a TODO on the PR comment

bentsku
bentsku commented Oct 2, 2024
View reviewed changes
HarshCasper
HarshCasper approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this now — I will add the link later

@HarshCasper HarshCasper marked this pull request as ready for review October 3, 2024 12:47
@HarshCasper HarshCasper merged commit 89ff32d into main Oct 3, 2024
5 checks passed
@HarshCasper HarshCasper deleted the apigw-next-gen branch October 3, 2024 12:47
@bentsku bentsku mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper HarshCasper approved these changes

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @HarshCasper @cloutierMat