Skip to content

Replace hardcoded URLs with ref shortcodes #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025
Merged

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented May 15, 2025

This PR replaces hardcoded internal links with the ref shortcode.

Hardcoded URLs don't work when hosting docs locally — they point to the deployed docs. The ref shortcode is better in this regard, plus it also detects broken links at build time.

Copy link

github-actions bot commented May 15, 2025

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1771.surge.sh 🎊

@viren-nadkarni viren-nadkarni self-assigned this May 15, 2025
@viren-nadkarni viren-nadkarni force-pushed the hardcoded-urls branch 2 times, most recently from 41ced7d to e55ee66 Compare May 15, 2025 14:09
@viren-nadkarni viren-nadkarni merged commit 310dfbd into main Jun 2, 2025
5 checks passed
@viren-nadkarni viren-nadkarni deleted the hardcoded-urls branch June 2, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants