remove multipart logic for follow-up

bentsku · bentsku · commit ad6e61931744 · 2025-01-25T00:53:41.000+01:00
diff --git a/localstack-core/localstack/services/s3/models.py b/localstack-core/localstack/services/s3/models.py
@@ -424,7 +424,6 @@ class S3Multipart:
     object: S3Object
     upload_id: MultipartUploadId
     checksum_value: Optional[str]
-    checksum_type: Optional[ChecksumType]
     initiated: datetime
     precondition: bool
 
@@ -435,7 +434,6 @@ def __init__(
         expires: Optional[datetime] = None,
         expiration: Optional[datetime] = None,  # come from lifecycle
         checksum_algorithm: Optional[ChecksumAlgorithm] = None,
-        checksum_type: Optional[ChecksumType] = ChecksumType.COMPOSITE,
         encryption: Optional[ServerSideEncryption] = None,  # inherit bucket
         kms_key_id: Optional[SSEKMSKeyId] = None,  # inherit bucket
         bucket_key_enabled: bool = False,  # inherit bucket
@@ -458,7 +456,6 @@ def __init__(
         self.initiator = initiator
         self.tagging = tagging
         self.checksum_value = None
-        self.checksum_type = checksum_type
         self.precondition = precondition
         self.object = S3Object(
             key=key,
@@ -468,7 +465,7 @@ def __init__(
             expires=expires,
             expiration=expiration,
             checksum_algorithm=checksum_algorithm,
-            checksum_type=checksum_type,
+            checksum_type=ChecksumType.COMPOSITE,
             encryption=encryption,
             kms_key_id=kms_key_id,
             bucket_key_enabled=bucket_key_enabled,
diff --git a/localstack-core/localstack/services/s3/provider.py b/localstack-core/localstack/services/s3/provider.py
@@ -2096,10 +2096,6 @@ def create_multipart_upload(
                 "Checksum algorithm provided is unsupported. Please try again with any of the valid types: [CRC32, CRC32C, SHA1, SHA256]"
             )
 
-        # TODO: validate the checksum map between COMPOSITE and FULL_OBJECT
-        # get value
-        checksum_type = request.get("ChecksumType")
-
         # TODO: we're not encrypting the object with the provided key for now
         sse_c_key_md5 = request.get("SSECustomerKeyMD5")
         validate_sse_c(
@@ -2126,7 +2122,6 @@ def create_multipart_upload(
             user_metadata=request.get("Metadata"),
             system_metadata=system_metadata,
             checksum_algorithm=checksum_algorithm,
-            checksum_type=checksum_type,
             encryption=encryption_parameters.encryption,
             kms_key_id=encryption_parameters.kms_key_id,
             bucket_key_enabled=encryption_parameters.bucket_key_enabled,
@@ -2151,7 +2146,6 @@ def create_multipart_upload(
 
         if checksum_algorithm:
             response["ChecksumAlgorithm"] = checksum_algorithm
-            response["ChecksumType"] = checksum_type
 
         add_encryption_to_response(response, s3_object=s3_multipart.object)
         if sse_c_key_md5:
@@ -2534,7 +2528,6 @@ def complete_multipart_upload(
         # TODO: check this?
         if s3_object.checksum_algorithm:
             response[f"Checksum{s3_object.checksum_algorithm.upper()}"] = s3_object.checksum_value
-            response["ChecksumType"] = s3_object.checksum_type
 
         if s3_object.expiration:
             response["Expiration"] = s3_object.expiration  # TODO: properly parse the datetime
@@ -2655,7 +2648,6 @@ def list_parts(
             response["PartNumberMarker"] = part_number_marker
         if s3_multipart.object.checksum_algorithm:
             response["ChecksumAlgorithm"] = s3_multipart.object.checksum_algorithm
-            response["ChecksumType"] = s3_multipart.checksum_type
 
         return response
 
