Skip to content

Revert "Add events method to docker clients (#9932)" #10025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jan 9, 2024

This reverts commit 94f9ddf.

Motivation

Since PR #9932, we are seeing flaky tests, especially in our arm64 builds.
Since these block the community pipeline, it's best to revert that commit for now, and reintroduce it with fixes later on.

Changes

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jan 9, 2024
@dfangl dfangl requested a review from alexrashed January 9, 2024 10:23
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! 🚀 💯

@dfangl dfangl force-pushed the revert-docker-events branch from 31254c5 to ec27241 Compare January 9, 2024 16:13
@dfangl dfangl merged commit 17fa5ee into master Jan 9, 2024
@dfangl dfangl deleted the revert-docker-events branch January 9, 2024 16:16
@coveralls
Copy link

Coverage Status

coverage: 83.975% (+0.03%) from 83.945%
when pulling ec27241 on revert-docker-events
into a5713c8 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants