Skip to content

fix Kinesis rejection of log level #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix Kinesis rejection of log level #10158

merged 1 commit into from
Feb 1, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 1, 2024

Motivation

I encountered this issue today:

2024-02-01T16:10:06.933  INFO --- [functhread10] localstack.utils.run       : Restarting process (received exit code 1): ['node', PosixPath('/Users/benjaminsimon/Projects/localstack/localstack/.filesystem/var/lib/localstack/lib/kinesis-local/0.4.5/node_modules/kinesis-local/main.js')]
2024-02-01T16:10:06.933 DEBUG --- [functhread10] localstack.utils.run       : Executing command: ['node', PosixPath('/Users/benjaminsimon/Projects/localstack/localstack/.filesystem/var/lib/localstack/lib/kinesis-local/0.4.5/node_modules/kinesis-local/main.js')]
2024-02-01T16:10:07.026  INFO --- [functhread10] l.s.k.kinesis_mock_server  : ciris.ConfigException: configuration loading failed with the following errors.
2024-02-01T16:10:07.026  INFO --- [functhread10] l.s.k.kinesis_mock_server  : 
2024-02-01T16:10:07.026  INFO --- [functhread10] l.s.k.kinesis_mock_server  : - TRACE-INTERNAL is not a member of Enum (ERROR, WARN, INFO, DEBUG, TRACE).
2024-02-01T16:10:07.026  INFO --- [functhread10] l.s.k.kinesis_mock_server  : 
2024-02-01T16:10:07.026  INFO --- [functhread10] l.s.k.kinesis_mock_server  : <no stack trace available>

It seems we already had logic in place for this kind of issue with warning level.

Changes

Added the trace-internal case and a fallback to info in case our log level is not in line with kinesis-mock ones.

@bentsku bentsku added aws:kinesis Amazon Kinesis semver: patch Non-breaking changes which can be included in patch releases labels Feb 1, 2024
@bentsku bentsku requested review from thrau and dfangl February 1, 2024 15:22
@bentsku bentsku self-assigned this Feb 1, 2024
thrau
thrau approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! LGTM :-)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 21m 28s ⏱️
2 618 tests 2 370 ✅ 248 💤 0 ❌
2 620 runs  2 370 ✅ 250 💤 0 ❌

Results for commit b74b220.

@bentsku bentsku merged commit e953ed3 into master Feb 1, 2024
@bentsku bentsku deleted the fix-kinesis-log-level branch February 1, 2024 21:08
maxhoheiser pushed a commit that referenced this pull request Feb 5, 2024
@bentsku @maxhoheiser
fix Kinesis rejection of log level (#10158)
9230626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dfangl dfangl dfangl approved these changes

Assignees

@bentsku bentsku

Labels
aws:kinesis Amazon Kinesis semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @thrau @dfangl