Skip to content

fine-tune workflow triggers #10194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2024
Merged

fine-tune workflow triggers #10194

merged 3 commits into from
Feb 13, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Feb 7, 2024 •
edited
Loading

Motivation

We have quite a lot of pipelines, where some of them are even triggered if the code change does not influence the pipeline at all (f.e. CODEOWNERS updates). Other pipeline triggers are not respecting recent changes to the dependency management (#10127).

This PR aims at fine-tuning and updating the pipeline triggers.

Changes

  • Fine tune the pipeline triggers.
  • Fixes the check that prevents the execution of the test-pro-integration workflow (which needs secrets to run) for forks (which don't have and should not have access to secrets).

TODO

  • Check if we can easily configure CircleCI to only trigger a workflow execution if the commit touches certain files.
    • Seems like this can only be done with a fairly complex feature called dynamic configuration.
    • This is considered too complicated for now.
  • Configure pipelines using secrets such that they are either skipped or work without secrets if they are not available.
    • This is necessary to fix the pipeline for community contributions. PRs coming from forks do not have access to any secrets other than the GitHub token assigned to the PR.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Feb 7, 2024
@alexrashed alexrashed self-assigned this Feb 7, 2024
@alexrashed alexrashed added this to the 3.2 milestone Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 27s ⏱️ +14s
386 tests ±0  336 ✅ ±0   50 💤 ±0  0 ❌ ±0 
772 runs  ±0  672 ✅ ±0  100 💤 ±0  0 ❌ ±0 

Results for commit 76683f7. ± Comparison against base commit 8aeabc1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 22m 44s ⏱️
2 626 tests 2 377 ✅ 249 💤 0 ❌
2 628 runs  2 377 ✅ 251 💤 0 ❌

Results for commit 25830fc.

@coveralls
Copy link

coveralls commented Feb 7, 2024 •
edited
Loading

Coverage Status

coverage: 83.84% (+0.009%) from 83.831%
when pulling 76683f7 on tune-ci-trigger
into 8aeabc1 on master.

@alexrashed alexrashed marked this pull request as ready for review February 13, 2024 14:01
dfangl
dfangl approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment regarding an exclusion.

@alexrashed alexrashed merged commit 3cce93c into master Feb 13, 2024
@alexrashed alexrashed deleted the tune-ci-trigger branch February 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@alexrashed alexrashed

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dfangl