Skip to content

Revert "Reduce requests necessary for lambda log publishing to cloudwatch logs" #10294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Feb 21, 2024

Reverts #10234

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Feb 21, 2024
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for unblocking the pipeline.

I can confirm this revert fixes the failing test in ext: tests.aws.services.apigateway.test_websocket_apis.TestWebSockets.test_websocket_with_lambda_integration

Re-introducing these changes after testing log format sanitation here seems the way to forward.

@dfangl dfangl merged commit 49395ac into master Feb 21, 2024
@dfangl dfangl deleted the revert-10234-lambda-logging-efficiency branch February 21, 2024 13:28
@coveralls
Copy link

Coverage Status

coverage: 83.865% (-0.01%) from 83.876%
when pulling c24bd0d on revert-10234-lambda-logging-efficiency
into b87f154 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants