Skip to content

split routing utilities not related to service operation routing out of op_router.py #11065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 20, 2024

Motivation

Follow up from #11057 and this comment: #11057 (review)

I've pulled everything not directly related to service-operation-routing out of op_router, in order to be able to use them in API Gateway resource routing as well.

Changes

  • pull some utilities outside of op_router.py into routing.py and update the imports

@bentsku bentsku added the semver: patch Non-breaking changes which can be included in patch releases label Jun 20, 2024
@bentsku bentsku self-assigned this Jun 20, 2024
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 22s ⏱️
404 tests 352 ✅  52 💤 0 ❌
808 runs  704 ✅ 104 💤 0 ❌

Results for commit 061aa47.

@bentsku bentsku added the aws:apigateway Amazon API Gateway label Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 35m 30s ⏱️ - 3m 45s
3 114 tests ±0  2 744 ✅ +4  370 💤 ±0  0 ❌ ±0 
3 116 runs  ±0  2 744 ✅ +4  372 💤 ±0  0 ❌ ±0 

Results for commit 061aa47. ± Comparison against base commit 946b273.

♻️ This comment has been updated with latest results.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! 🧹
Nice to see that these few utility functions for custom routing are also useful for the new APIGW routing!

@bentsku bentsku merged commit 8154733 into master Jun 21, 2024
42 checks passed
@bentsku bentsku deleted the refactor-op-router branch June 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants