Skip to content

add empty integrations for NG APIGW #11099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2024
Merged

add empty integrations for NG APIGW #11099

merged 3 commits into from
Jun 27, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 27, 2024 •
edited
Loading

Motivation

This is first iteration to introduce the different REST API integrations.
The first idea was to use Plugins for each different IntegrationType, which allows easy discovery and to extend the list of integration in a transparent way.

However, while working on the AWS integration type, it became apparent that we could pull off all AWS services with a single integration, with no need to subclass like the current code does (we have KinesisIntegration, S3Integration...). But it happens that the AWS integration has the same logic for every service, and we will work to make it possible in the new iteration.

Changes

  • create the different Integration types with their base class and some documentation

@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases labels Jun 27, 2024
@bentsku bentsku self-assigned this Jun 27, 2024
@bentsku bentsku mentioned this pull request Jun 27, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   22m 56s ⏱️ - 1h 12m 5s
643 tests  - 2 508  598 ✅  - 2 157  45 💤  - 351  0 ❌ ±0 
645 runs   - 2 508  598 ✅  - 2 157  47 💤  - 351  0 ❌ ±0 

Results for commit 7a5b2c3. ± Comparison against base commit 79a10dc.

This pull request removes 2508 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@bentsku bentsku changed the title add integration plugins for NG APIGW add empty integrations for NG APIGW Jun 27, 2024
@bentsku bentsku marked this pull request as ready for review June 27, 2024 14:02
@bentsku bentsku requested a review from cloutierMat as a code owner June 27, 2024 14:02
cloutierMat
cloutierMat approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

localstack-core/localstack/services/apigateway/next_gen/execute_api/handlers/integration.py
)

integration_response = integration.invoke(context)
response.update_from(integration_response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that is keeping things nice and simple! 🚀

@bentsku bentsku merged commit adc580c into master Jun 27, 2024
33 checks passed
@bentsku bentsku deleted the apigw-add-integration-plugin branch June 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels
aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @cloutierMat