APIGW NG fix routing with ANY request and remove stage from path
#11129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 23m 25s ⏱️ - 1h 10m 46s Results for commit 8854284. ± Comparison against base commit faf13f7. This pull request removes 2518 tests. |
2 tasks
cloutierMat
approved these changes
Jul 4, 2024
Comment on lines
+50
to
+52
| # Make sure Werkzeug's Rule does not add any other methods | ||
| # (f.e. the HEAD method even though the rule should only match GET) | ||
| self.methods = {method.upper()} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As @cloutierMat reported, when actually using the next gen APIGW provider, we would not properly route requests, because we had the full path containing the
stagewhich didn't map properly to any created Werkzeug Rule. This is how APIGW represents theirpath, this is only what is after thestage.Only the
$context.pathcontains thestageandpath, so we can get weird snapshot with one field namedpathcontaining/your-pathand one namedrequestContext.pathcontaining/stage-name/your-path. 🤷♂️We also had the issue with the
ANYmethod, we would try to pass that when creating a Werkzeug Rule.We now create a special case where
ANYgets mapped toDELETE,GET,HEAD,OPTIONS,PATCH,POST, andPUT(the supported HTTP methods of APIGW).I was worried about having a rule order issue in Werkzeug, but this proved to not be a problem because we only return the
Resourcefrom the match, and we can manually get the rightresourceMethodafterwards.Changes
ANYmethodANYmethod with different order of creationRequestpath