Skip to content

apigw next gen add circle ci pipeline #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Jul 17, 2024

Motivation

Now that we have a set of stable feature for the apigw Next Gen and all tests are now green 🥳 . We are adding a new pipeline for apigw to help ensure we don't introduce any regression as we keep working on new features and extend the work to apigwv2.

PR #11198 enabled all tests and links to run https://app.circleci.com/jobs/github/localstack/localstack/227232 that was executed with the flag enabled.

Changes

A new pipeline for circle-ci that sets PROVIDER_OVERRIDE_APIGATEWAY=next_gen

@cloutierMat cloutierMat self-assigned this Jul 17, 2024
@cloutierMat cloutierMat added the semver: patch Non-breaking changes which can be included in patch releases label Jul 17, 2024
@cloutierMat cloutierMat added this to the 3.6 milestone Jul 17, 2024
@cloutierMat cloutierMat requested a review from bentsku July 18, 2024 00:08
@cloutierMat cloutierMat marked this pull request as ready for review July 18, 2024 00:08
Copy link

github-actions bot commented Jul 18, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 36m 25s ⏱️ +41s
3 206 tests ±0  2 804 ✅ ±0  402 💤 ±0  0 ❌ ±0 
3 208 runs  ±0  2 804 ✅ ±0  404 💤 ±0  0 ❌ ±0 

Results for commit 6f0a94b. ± Comparison against base commit 5760111.

♻️ This comment has been updated with latest results.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that the new provider is going to be properly tested along the way! The integration is straight-forward, pretty much the same as for other alternative providers. 🚀 💯

Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice to see we can now run the full test suite 🚀

@cloutierMat cloutierMat merged commit 91c4dff into master Jul 18, 2024
33 checks passed
@cloutierMat cloutierMat deleted the apigw-ng-add-circle-ci-pipeline branch July 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants