Skip to content

fix cloudwatch get_metric_data for multiple dimensions #11270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2024
Merged

fix cloudwatch get_metric_data for multiple dimensions #11270

merged 4 commits into from
Jul 29, 2024

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented Jul 26, 2024 •
edited by pinzon
Loading

Motivation

We had a report stating that issues with the new CloudWatch provider. I was able to reproduce the issue and added a test for it - the issue relates to multiple dimensions.

Changes

  • Added test
  • fixed the logic for multiple dimension selection

TODO

What's left to do:

  • fix broken test_list_metrics_with_filters

@steffyP steffyP added the semver: patch Non-breaking changes which can be included in patch releases label Jul 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   30m 53s ⏱️ - 1h 5m 37s
835 tests  - 2 467  783 ✅  - 2 125  52 💤  - 342  0 ❌ ±0 
837 runs   - 2 467  783 ✅  - 2 125  54 💤  - 342  0 ❌ ±0 

Results for commit f0b34d7. ± Comparison against base commit 428882f.

This pull request removes 2468 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_multiple_dimensions_statistics

♻️ This comment has been updated with latest results.

@steffyP steffyP marked this pull request as ready for review July 26, 2024 15:45
@steffyP steffyP requested a review from pinzon as a code owner July 26, 2024 15:45
@steffyP steffyP changed the title fix cloudwatch get_metric_data fix cloudwatch get_metric_data for multiple dimensions Jul 26, 2024
@steffyP steffyP force-pushed the cw-fix-get-statistics branch from 5a6f1e6 to f0b34d7 Compare July 29, 2024 07:59
@steffyP steffyP added this to the 3.7 milestone Jul 29, 2024
@steffyP steffyP self-assigned this Jul 29, 2024
@steffyP steffyP merged commit 1aad84d into master Jul 29, 2024
33 checks passed
@steffyP steffyP deleted the cw-fix-get-statistics branch July 29, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

Assignees

@steffyP steffyP

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@steffyP @pinzon