Skip to content

upgrade ffmpeg to use version 7.0.1 #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

upgrade ffmpeg to use version 7.0.1 #11294

merged 1 commit into from
Aug 1, 2024

Conversation

sannya-singal
Copy link
Contributor

@sannya-singal sannya-singal commented Aug 1, 2024 •
edited
Loading

Motivation

As a follow up to PR: #11261, we decided to upgrade the ffmpeg package version. Currently we use an old release version 4.4.1, for more information check out: https://www.johnvansickle.com/ffmpeg/old-releases.

Changes

Upgrade the package to the latest release: 7.0.1.

@sannya-singal sannya-singal added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 1, 2024
@sannya-singal sannya-singal self-assigned this Aug 1, 2024
@sannya-singal sannya-singal requested a review from bentsku August 1, 2024 06:45
@sannya-singal sannya-singal marked this pull request as ready for review August 1, 2024 06:45
alexrashed
alexrashed approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade! 💯
In the future we could maybe think about an automated approach for all the installers... 🤔

@sannya-singal
Copy link
Contributor Author

sannya-singal commented Aug 1, 2024 •
edited
Loading

Yes we could actually run a cron job to check for all the latest stable versions of the installers and atleast list out the warnings for the deprecated ones/ the packages that use a version with say ~>1.5yr older release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 36m 18s ⏱️ + 1m 1s
3 304 tests ±0  2 910 ✅ ±0  394 💤 ±0  0 ❌ ±0 
3 306 runs  ±0  2 910 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 103419c. ± Comparison against base commit b525bc8.

@alexrashed
Copy link
Member

Well, I think we should aim for a more generalized approach.
A lot of installers directly reference specific versions, however, often it's easy to generalize the lookup for new versions, and maybe even build a mechanism for automated code updates.
But really just something to think about, it's definitely not necessary to build any kind of mechanisms for single packages right now.

@sannya-singal sannya-singal merged commit 31f3a39 into master Aug 1, 2024
38 checks passed
@sannya-singal sannya-singal deleted the ffmpeg_upgrade branch August 1, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@bentsku bentsku Awaiting requested review from bentsku

Assignees

@sannya-singal sannya-singal

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sannya-singal @alexrashed