fix APIGW CFN Stage with Stage Variables casing #11344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cloutierMat
approved these changes
Aug 12, 2024
localstack-core/localstack/services/apigateway/resource_providers/aws_apigateway_stage.py
Outdated
Show resolved
Hide resolved
Comment on lines
-1260
to
-1265
| case "AWS": | ||
| case _: | ||
| integration_method = ( | ||
| method_integration.get("httpMethod") or method_name | ||
| ).upper() | ||
| case _: | ||
| integration_method = method_name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported by a user, we had an issue with stage variables when declared via CloudFormation.
Setting a stage variable to be
TestCasingwould save it astestCasing. As stage variables are case sensitive, this is quite an issue.I've tracked down the issue to be because we would call
keys_to_loweron the parameters, which would change the casing.In the meantime, I've added more tests around stage variables and their casing without CFN, and more validation about what the user was encoutering (the stage variable wouldn't be found, which would create an HTTP integration URI to not have a host).
I've also found a small issue with how we would import OpenAPI/Swagger files for the method used for the integration for HTTP/HTTP_PROXY.
Resources:
Changes
Stageresource for APIGW, picking up the stage variables before thekeys_to_lowercall and using deep copy because of the nested dictsHTTP&HTTP_PROXYNextGen integrations, can still be improved with negative testing, we just need to find how to trigger them