Skip to content

Updated parameter mapper typing #11413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2024
Merged

Updated parameter mapper typing #11413

merged 1 commit into from
Aug 26, 2024

Conversation

cloutierMat
Copy link
Contributor

Motivation

Improve re-usability of the helper method by expanding it's typing to accept all dict.

@cloutierMat cloutierMat added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases labels Aug 26, 2024
@cloutierMat cloutierMat added this to the 3.7 milestone Aug 26, 2024
@cloutierMat cloutierMat self-assigned this Aug 26, 2024
@cloutierMat cloutierMat requested a review from bentsku as a code owner August 26, 2024 16:04
bentsku
bentsku approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   24m 55s ⏱️ - 1h 10m 44s
785 tests  - 2 626  732 ✅  - 2 281  53 💤  - 345  0 ❌ ±0 
787 runs   - 2 626  732 ✅  - 2 281  55 💤  - 345  0 ❌ ±0 

Results for commit afdc876. ± Comparison against base commit ff1c31b.

This pull request removes 2626 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@cloutierMat cloutierMat merged commit b64faaa into master Aug 26, 2024
41 checks passed
@cloutierMat cloutierMat deleted the apigw-ng-improve-parameter-reusability branch August 26, 2024 16:34
@bentsku bentsku mentioned this pull request Aug 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

Assignees

@cloutierMat cloutierMat

Labels
aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@cloutierMat @bentsku