fix deletion of failed nested stack in CFn #11489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77226ec to
0872119
Compare
simonrw
approved these changes
Sep 13, 2024
| @@ -81,7 +82,7 @@ def test_nested_stack_output_refs(deploy_cfn_template, s3_create_bucket, aws_cli | |||
| assert f"{nested_bucket_name}-suffix" == result.outputs["CustomOutput"] | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Nested stacks don't work properly") | |||
| @pytest.mark.skip(reason="Nested rtacks don't work properly") | |||
There was a problem hiding this comment.
Suggested change
| @pytest.mark.skip(reason="Nested rtacks don't work properly") | |
| @pytest.mark.skip(reason="Nested stacks don't work properly") |
There was a problem hiding this comment.
An error from my part but thanks to it I found that we can delete the skip
Comment on lines
345
to
350
| def _stack_and_child_deleted(): | ||
| stacks = aws_client.cloudformation.describe_stacks()["Stacks"] | ||
| stacks_with_name = [s for s in stacks if stack_name in s["StackName"]] | ||
| assert len(stacks_with_name) == 0 | ||
|
|
||
| retry(_stack_and_child_deleted, sleep=2 if is_aws_cloud() else 1) |
There was a problem hiding this comment.
Could you use a waiter here? Also it might be clearer to describe_stack(StackName=stack_name) and catch the exception?
There was a problem hiding this comment.
Took a while but test is a lot better now. I'll merge once is green.
a54f267 to
229c705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses #10826. The resource_provider class only stores the new model properties if the create operation is successful. This can cause issues where a nested stack reaches a failed status after being in a pending state. The Id property is never stored, and if the delete method is called, the property required for deletion cannot be found.
Changes
Testing