Skip to content

Feature/Events: Add internal log messages #11579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

Feature/Events: Add internal log messages #11579

merged 1 commit into from
Sep 26, 2024

Conversation

maxhoheiser
Copy link
Member

Motivation

EventStudio open the black box eventbridge as an event router represents, therefore it is highly beneficial to surface internal steps that can be the cause for mismatches between expected behavior and actual behavior e.g. no rule matches the message.
Therefore log messages are added at these specific instances.

@maxhoheiser maxhoheiser added aws:events Amazon EventBridge semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Sep 25, 2024
@maxhoheiser maxhoheiser self-assigned this Sep 25, 2024
@maxhoheiser maxhoheiser marked this pull request as ready for review September 25, 2024 15:31
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   56m 17s ⏱️ - 40m 35s
1 935 tests  - 1 508  1 753 ✅  - 1 292  182 💤  - 216  0 ❌ ±0 
1 937 runs   - 1 508  1 753 ✅  - 1 292  184 💤  - 216  0 ❌ ±0 

Results for commit 45cf251. ± Comparison against base commit 83f7b3c.

This pull request removes 1508 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

Morijarti
Morijarti approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Morijarti Morijarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see addition of structured logs.
Are we using similar logs in other parts of LS?

@maxhoheiser maxhoheiser merged commit 650483e into master Sep 26, 2024
39 checks passed
@maxhoheiser maxhoheiser deleted the feature/events/eventstudio-internal-log-messages branch September 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morijarti Morijarti Morijarti approved these changes

@joe4dev joe4dev Awaiting requested review from joe4dev

Assignees

@maxhoheiser maxhoheiser

Labels
aws:events Amazon EventBridge semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxhoheiser @Morijarti