Skip to content

Reject events larger than the max size allowed #11623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Reject events larger than the max size allowed #11623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99fa091
Reject events larger than the max size allowed
xocasdashdash Oct 2, 2024
e413de5
reformated files
xocasdashdash Oct 2, 2024
ddce04c
feat: fix test too big
maxhoheiser Oct 18, 2024
bedf6e5
feat: add snapshots
maxhoheiser Oct 18, 2024
8168879
feat: fix validation detail too big
maxhoheiser Oct 18, 2024
bf2fc7a
Merge remote-tracking branch 'fork-origin/master'
xocasdashdash Nov 20, 2024
f3c1bac
added the event again after dropping it in the merge
xocasdashdash Nov 20, 2024
d8c3195
fixed lint
xocasdashdash Nov 20, 2024
cb37d29
Merge remote-tracking branch 'fork-origin/master'
xocasdashdash Nov 20, 2024
fec9336
Merge remote-tracking branch 'upstream/master'
maxhoheiser Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions localstack-core/localstack/services/events/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ def validate_event(event: PutEventsRequestEntry) -> None | PutEventsResultEntry:
"ErrorCode": "InvalidArgument",
"ErrorMessage": "Parameter Detail is not valid. Reason: Detail is a required argument.",
}
elif event.get("Detail") and len(event["Detail"]) >= 262144:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can assume that the detail exists here of it would have gone through line 197

Suggested change
elif event.get("Detail") and len(event["Detail"]) >= 262144:
elif len(event["Detail"]) >= 262144:

raise ValidationException("Total size of the entries in the request is over the limit.")


def check_unique_tags(tags: TagsList) -> None:
Expand Down
18 changes: 18 additions & 0 deletions tests/aws/services/events/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,24 @@ def test_put_event_without_detail(self, snapshot, aws_client):
response = aws_client.events.put_events(Entries=entries)
snapshot.match("put-events", response)

@markers.aws.validated
@pytest.mark.skipif(
is_old_provider(),
reason="V1 provider does not support this feature",
)
def test_put_event_with_too_big_detail(self, snapshot, aws_client):
entries = [
{
"Source": TEST_EVENT_PATTERN_NO_DETAIL["source"][0],
"DetailType": TEST_EVENT_PATTERN_NO_DETAIL["detail-type"][0],
"Detail": json.dumps({"payload": ["p" * (256 * 1024 - 17)]}),
},
]

with pytest.raises(ClientError) as e:
aws_client.events.put_events(Entries=entries)
snapshot.match("put-events-too-big-detail-error", e.value.response)

@markers.aws.validated
@pytest.mark.skipif(
is_old_provider(),
Expand Down
16 changes: 15 additions & 1 deletion tests/aws/services/events/test_events.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,21 @@
]
}
},
"tests/aws/services/events/test_events.py::TestEvents::test_create_connection_validations": {
"tests/aws/services/events/test_events.py::TestEvents::test_put_event_with_too_big_detail": {
"recorded-date": "18-10-2024, 07:36:18",
"recorded-content": {
"put-events-too-big-detail-error": {
"Error": {
"Code": "ValidationException",
"Message": "Total size of the entries in the request is over the limit."},
"ResponseMetadata": {
"HTTPHeaders": {},
"HTTPStatusCode": 400
}
}
}
},
"tests/aws/services/events/test_events.py::TestEvents::test_create_connection_validations": {
"recorded-date": "14-11-2024, 20:29:49",
"recorded-content": {
"create_connection_exc": {
Expand Down
3 changes: 3 additions & 0 deletions tests/aws/services/events/test_events.validation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@
"tests/aws/services/events/test_events.py::TestEvents::test_create_connection_validations": {
"last_validated_date": "2024-11-14T20:29:49+00:00"
},
"tests/aws/services/events/test_events.py::TestEvents::test_put_event_with_too_big_detail": {
"last_validated_date": "2024-10-18T07:36:18+00:00"
},
"tests/aws/services/events/test_events.py::TestEvents::test_put_event_without_detail": {
"last_validated_date": "2024-06-19T10:40:51+00:00"
},
Expand Down
Loading