Skip to content

ESM-v2: fix IAM service principal #11648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

ESM-v2: fix IAM service principal #11648

merged 2 commits into from
Oct 7, 2024

Conversation

gregfurman
Copy link
Contributor

Motivation

Addresses IAM regressions raised in new ESM v2.

Changes

  • Change the service principal from Pipes to Lambda.

@gregfurman gregfurman self-assigned this Oct 7, 2024
@gregfurman gregfurman added aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases labels Oct 7, 2024
@gregfurman gregfurman added this to the 3.8 milestone Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 19m 30s ⏱️
2 557 tests 2 239 ✅ 318 💤 0 ❌
2 559 runs  2 239 ✅ 320 💤 0 ❌

Results for commit 6c1b703.

@gregfurman gregfurman marked this pull request as ready for review October 7, 2024 10:43
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The key point here is that there should be no IAM enforcement when lambda ESM invokes the lambda it is attached too! It happens within the service, and there is no permission for that.

@dfangl dfangl merged commit 9645ec2 into master Oct 7, 2024
35 checks passed
@dfangl dfangl deleted the fix/esm/iam branch October 7, 2024 11:42
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants