-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Bump moto-ext to 5.0.17.post1 #11659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 29s ⏱️ Results for commit 27dde67. ♻️ This comment has been updated with latest results. |
I've pushed bb272e0 to fix a regression in Moto introduced by getmoto/moto#8202 (not only a strict match, AWS also accepts a prefix for an API key), I'll also open a PR in moto to fix it, but figured it'd be easier here, as we are planning to move away, so the more logic we have in the provider the better. |
bb272e0
to
8df1869
Compare
requirements-base-runtime.txt
Outdated
@@ -1,5 +1,5 @@ | |||
# | |||
# This file is autogenerated by pip-compile with Python 3.11 | |||
# This file is autogenerated by pip-compile with Python 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be the case just yet 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I upgraded to Ubuntu 24.04 yesterday, and yes Python 3.12 makes more than just a cosmetic impact.
Reverted with 27dde67 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pro-tip: Use pyenv
. We do have .python-version
files in our repos, which controls pyenv
to automatically switch to the right version. :)
9dd4402
to
af3cfae
Compare
I've rebased the PR following #11651, and added the last fix in the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for keeping moto(-ext) up to date, and thanks for the great team-work to fix incompatibilities! 💯
Co-authored-by: Benjamin Simon <benjh.simon@gmail.com>
Summary
This PR bumps moto-ext to 5.0.17.post1
Contains:
To do