Skip to content

Bump moto-ext to 5.0.17.post1 #11659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Bump moto-ext to 5.0.17.post1 #11659

merged 6 commits into from
Oct 15, 2024

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Oct 9, 2024

Copy link

github-actions bot commented Oct 9, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 29s ⏱️
423 tests 369 ✅  54 💤 0 ❌
846 runs  738 ✅ 108 💤 0 ❌

Results for commit 27dde67.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 18s ⏱️ + 1m 57s
3 493 tests ±0  3 080 ✅ ±0  413 💤 ±0  0 ❌ ±0 
3 495 runs  ±0  3 080 ✅ ±0  415 💤 ±0  0 ❌ ±0 

Results for commit 27dde67. ± Comparison against base commit 3a32828.

♻️ This comment has been updated with latest results.

@bentsku
Copy link
Contributor

bentsku commented Oct 10, 2024

I've pushed bb272e0 to fix a regression in Moto introduced by getmoto/moto#8202 (not only a strict match, AWS also accepts a prefix for an API key), I'll also open a PR in moto to fix it, but figured it'd be easier here, as we are planning to move away, so the more logic we have in the provider the better.

@viren-nadkarni viren-nadkarni self-assigned this Oct 10, 2024
@viren-nadkarni viren-nadkarni changed the title Bump moto-ext to 5.0.16.post1 Bump moto-ext to 5.0.17.post1 Oct 14, 2024
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be the case just yet 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded to Ubuntu 24.04 yesterday, and yes Python 3.12 makes more than just a cosmetic impact.

Reverted with 27dde67 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro-tip: Use pyenv. We do have .python-version files in our repos, which controls pyenv to automatically switch to the right version. :)

@bentsku
Copy link
Contributor

bentsku commented Oct 15, 2024

I've rebased the PR following #11651, and added the last fix in the unit tests

@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 15, 2024 07:58
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for keeping moto(-ext) up to date, and thanks for the great team-work to fix incompatibilities! 💯

@viren-nadkarni viren-nadkarni merged commit 4f4e440 into master Oct 15, 2024
51 checks passed
@viren-nadkarni viren-nadkarni deleted the bump-moto-ext branch October 15, 2024 08:28
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
Co-authored-by: Benjamin Simon <benjh.simon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants