ESM v2: Add EventSourceMappingArn field #11675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
commented
Oct 11, 2024
| @@ -21,6 +21,6 @@ def snapshot(request, _snapshot_session: SnapshotSession, account_id, region_nam | |||
| RegexTransformer(f"arn:{get_partition(region_name)}:", "arn:<partition>:"), priority=2 | |||
| ) | |||
|
|
|||
| _snapshot_session.add_transformer(SNAPSHOT_BASIC_TRANSFORMER_NEW, priority=2) | |||
| _snapshot_session.add_transformer(SNAPSHOT_BASIC_TRANSFORMER_NEW, priority=0) | |||
There was a problem hiding this comment.
The uuid of each ESM was being snapshot as a resource, this priority ordering change fixes that.
0a6579e to
32951a2
Compare
32951a2 to
54fea06
Compare
336edd5 to
ba5069a
Compare
ba5069a to
5ad6527
Compare
pinzon
reviewed
Oct 15, 2024
|
@pinzon The |
macnev2013
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces increases parity with AWS by includng a new field in ESM responses.
Changes
EventSourceMappingArnfield to config:conftest.pyto better cater for this case of multiple UUIDs being snapshot.