Skip to content

APIGW NG: fix storing store attribute instead of full store #11702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

APIGW NG: fix storing store attribute instead of full store #11702

merged 1 commit into from
Oct 21, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 16, 2024

Motivation

As reported in #11696, we've had an issue with APIGW NG persistence. We need to store the actual full store variable (container) instead of some of its dict attributes, as those could be overwritten (replacing a nested dict value with another dict, thus losing the "sync" and reference).

Changes

  • store the full account bundle instead of the store, and create a property to access the store itself

@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases labels Oct 16, 2024
@bentsku bentsku self-assigned this Oct 16, 2024
@bentsku bentsku requested a review from cloutierMat as a code owner October 16, 2024 20:44
@bentsku bentsku mentioned this pull request Oct 16, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   25m 18s ⏱️ - 1h 16m 22s
813 tests  - 2 695  755 ✅  - 2 340  58 💤  - 355  0 ❌ ±0 
815 runs   - 2 695  755 ✅  - 2 340  60 💤  - 355  0 ❌ ±0 

Results for commit 4622bf4. ± Comparison against base commit 8c9d9b0.

This pull request removes 2695 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

cloutierMat
cloutierMat approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Neat fix 🚀

@bentsku bentsku force-pushed the apigw-ng-fix-persistence branch 3 times, most recently from 5401152 to 7390277 Compare October 18, 2024 14:17
@bentsku bentsku force-pushed the apigw-ng-fix-persistence branch from 7390277 to 4622bf4 Compare October 21, 2024 10:28
@bentsku bentsku merged commit a273e83 into master Oct 21, 2024
34 checks passed
@bentsku bentsku deleted the apigw-ng-fix-persistence branch October 21, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels
aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @cloutierMat