Add special handling of bedrock-runtime service in service router #11706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 32s ⏱️ Results for commit b54fd87. ♻️ This comment has been updated with latest results. |
alexrashed
requested changes
Oct 17, 2024
There was a problem hiding this comment.
We have an automated test which basically tests every single possible endpoint.
For bedrock, this is currently disabled because it did not work.
Would be great to remove this exclusion to verify that your fix actually works.
Afterwards we should be good to go! 🚀
alexrashed
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As
bedrockandbedrock-runtimehave the same signing namebedrock,bedrock-runtimerequests are directed to the/modelpath. This is similar to howsagemaker-runtimealso works.Changes
bedrockto send requests to/model/and/guardrail/to thebedrock-runtimeprovider.bedrockandbedrock-runtime