improve tests selection #11721
Merged
improve tests selection #11721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
Oct 22, 2024
Comment on lines
96
to
97
| def directory(self, paths: list[str] = None): | ||
| return lambda t: (paths or [get_directory(t)]) if self.matching_func(t) else [] |
There was a problem hiding this comment.
nits:
- Would it make sense to explain the behavior of this function quickly in a docstring?
- I think it would be great if this new behavior would be tested in the unit tests of this module:
https://github.com/localstack/localstack/blob/master/tests/unit/testing/testselection/test_matching.py
There was a problem hiding this comment.
Agreed, I will write some tests and documentation for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to expand on the functionality of the
Matcherfor tests selection. The changes included will allow us to use thedirectorymethod to add an argument for which directory should be executed.Changes
We can now enter the following rule to explicitly target test folders when files in
my_featuremodules are changed.