Skip to content

Convert SQS test util into re-usable fixture sqs_collect_messages #11757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Convert SQS test util into re-usable fixture sqs_collect_messages #11757

merged 1 commit into from
Oct 29, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Oct 28, 2024

Motivation

Collecting SQS messages is a common task in LocalStack testing and we don't have a re-usable fixture (across LS and LS-ext) yet. The fixture is used in a LS-ext PR for testing Pipes persistence.

Changes

  • Convert SQS helper util into re-usable fixture sqs_collect_messages

Discussion

When should we use fixtures and when util/helper methods (passing in an aws_client)?

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Oct 28, 2024
@joe4dev joe4dev self-assigned this Oct 28, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 36s ⏱️ +56s
3 510 tests ±0  3 097 ✅ ±0  413 💤 ±0  0 ❌ ±0 
3 512 runs  ±0  3 097 ✅ ±0  415 💤 ±0  0 ❌ ±0 

Results for commit 99473c6. ± Comparison against base commit 0338932.

@joe4dev joe4dev marked this pull request as ready for review October 28, 2024 20:23
thrau
thrau approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! 💯 it makes sense to me to have this as a re-usable fixture. i was looking briefly into making this into a boto waiter but found it to be too cumbersome, so just went for the fixture instead.

@thrau thrau merged commit 184e55d into master Oct 29, 2024
37 checks passed
@thrau thrau deleted the feature/pipes-persistence branch October 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@baermat baermat Awaiting requested review from baermat baermat is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@joe4dev joe4dev

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @thrau