Skip to content

migrate to LOCALSTACK_AUTH_TOKEN #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

alexrashed
Copy link
Member

Motivation

With the upcoming release of LocalStack v4, we will push the deprecation of LOCALSTACK_API_KEY in favor of LOCALSTACK_AUTH_TOKEN.
This PR prepares this deprecation by migrating all usages of the API key in favor of the auth token.
This change does not introduce any deprecation message yet.

Changes

  • Use LOCALSTACK_AUTH_TOKEN instead of LOCALSTACK_API_KEY wherever possible.
  • Avoid directing users to set a LOCALSTACK_API_KEY in case no credentials are set.

/cc @Pive01 @SimonWallner

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Oct 30, 2024
@alexrashed alexrashed added this to the 4.0 milestone Oct 30, 2024
@alexrashed alexrashed self-assigned this Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 33s ⏱️ +39s
3 532 tests ±0  3 118 ✅ ±0  414 💤 ±0  0 ❌ ±0 
3 534 runs  ±0  3 118 ✅ ±0  416 💤 ±0  0 ❌ ±0 

Results for commit e59d58b. ± Comparison against base commit 1db9b8f.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed marked this pull request as ready for review October 31, 2024 08:25
@alexrashed alexrashed force-pushed the prep-api-key-deprecation branch from f839e1d to 9acd91b Compare October 31, 2024 14:25
@alexrashed alexrashed force-pushed the prep-api-key-deprecation branch from 9acd91b to e59d58b Compare November 4, 2024 16:34
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup! LGTM

@alexrashed alexrashed merged commit 37b129f into master Nov 7, 2024
34 checks passed
@alexrashed alexrashed deleted the prep-api-key-deprecation branch November 7, 2024 16:41
zaingz pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants